Conversation
|
Doc build failed? |
|
Yes, everything failed earlier this morning due to network issues. I've restarted them all. |
anntzer
left a comment
There was a problem hiding this comment.
Seems more natural to just check_isinstance(BboxBase, bbox=bbox) if we want to go that direction, no? (Also consistent with the line immediately after.)
Feel free to dismiss if you disagree.
Except that a TypeError will be raised. Which on the other hand makes more sense. I can change if there is agreement on this. Edit: this also raises the question if |
|
I added the change as a second commit. Not sure if I should deprecate it as a property or classproperty though. |
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
PR summary
Passing something else than a
Transformwould lead to anAttributeError, but now the better error message should show up.PR checklist