TST: Use importlib for importing in pytest#27552
Conversation
|
Interestingly, this seems to be fine on the Minimum Versions CI, but everywhere else doesn't like it. That build uses pytest 7.0.0, and locally I have 7.2.1. The other jobs appear to be 7.4.3. I will have to investigate whether that might be the cause of the problem. |
|
And on Windows, I have pytest 7.4.0 which works. |
|
And updating my Windows machine to 7.4.3 also works, so it seems to be something else. |
|
If I launch the tests as it works If I launch the tests as it fails locally works. |
|
Ah right; I think what we'd want is But to continue, do we want to:
|
|
I think we want to:
There was a big push to move everything to |
eb24233 to
f2b2ee0
Compare
|
OK, now we can see that that leak test if failing as: It appears that Cygwin broke a while ago, and I've opened pybind/pybind11#4999 for that. |
f2b2ee0 to
243e307
Compare
243e307 to
8d7f768
Compare
This fixes the rewriting so that we get detailed variable information again, which was broken with the move to Meson (which does weird import hacking for editable installs.)
8d7f768 to
88e6aeb
Compare
PR summary
This fixes the rewriting so that we get detailed variable information again, which was broken with the move to Meson (which does weird import hacking for editable installs.)
PR checklist