BLD: Downgrade FreeType to 2.6.1 on Windows ARM#27676
Merged
tacaswell merged 1 commit intomatplotlib:mainfrom Jan 22, 2024
Merged
BLD: Downgrade FreeType to 2.6.1 on Windows ARM#27676tacaswell merged 1 commit intomatplotlib:mainfrom
tacaswell merged 1 commit intomatplotlib:mainfrom
Conversation
We needed the new version because autotools didn't know about Windows-on-ARM. But we build with Meson now, and overlay a Meson build system for FreeType, so it either works for both of us or it doesn't (and it does). Dropping down to the older version means that tests pass on Windows ARM without any need to mess with tolerance or generating new images.
tacaswell
approved these changes
Jan 22, 2024
Member
|
I'm going to merge this on just my review because @QuLogic has an windows ARM test box. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
We needed the new version because autotools didn't know about Windows-on-ARM. But we build with Meson now, and overlay a Meson build system for FreeType, so it either works for both of us or it doesn't (and it does).
Dropping down to the older version means that tests pass on Windows ARM without any need to mess with tolerance or generating new images.
Note: we don't build for Windows on ARM because dependencies aren't there, but they're quite close, so we can enable that soon.
PR checklist