CI: skip code coverage upload on scheduled tests#27688
Merged
QuLogic merged 2 commits intomatplotlib:mainfrom Jan 23, 2024
Merged
CI: skip code coverage upload on scheduled tests#27688QuLogic merged 2 commits intomatplotlib:mainfrom
QuLogic merged 2 commits intomatplotlib:mainfrom
Conversation
This is to keep coverage in the test suite up
tacaswell
force-pushed
the
ci/pytest_pre
branch
from
4630eaf to
cfac81d
Compare
Contributor
|
Alternatively, should we just add the logic to not upload to codecov during our weekly scheduled event? |
Member
Author
|
oh, that did not even occur to me as an option! That is probably a better choice. |
Member
Author
|
I'm happy with either solution I can either squash these commits or drop the second one. |
greglucas
approved these changes
Jan 23, 2024
Contributor
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
I'm also fine with either version, with a slight preference for how it is now and ignoring code-cov on the more "unique" run to avoid other potential whack-a-mole issues later.
rcomer
approved these changes
Jan 23, 2024
Member
rcomer
left a comment
rcomer
left a comment
There was a problem hiding this comment.
The current solution also presumably makes the cron job slightly more efficient so makes sense to me.
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to keep coverage in the test suite up and reduce false-negatives on PRs.
After the pre-release cron job runs the base coverage includes additional uploads.