Simplify Figure._suplabels. #27728
Merged
Simplify Figure._suplabels. #27728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on alias normalization machinery to make alias checking simpler and more robust (there are also aliases for fontproperties which were not checked before). While at it, also slightly reorder Text aliases (this has no actual visible effect) to have the font properties and the alignments grouped.
QuLogic
approved these changes
Feb 1, 2024
oscargus
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rely on alias normalization machinery to make alias checking simpler and more robust (there are also aliases for fontproperties which were not checked before).
While at it, also slightly reorder Text aliases (this has no actual visible effect) to have the font properties and the alignments grouped.
Noted via #27630 (this should not interfere with the current PR for that issue).
PR summary
PR checklist