Remove self._renderer from AnnotationBbox and ConnectionPatch#27806
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Feb 21, 2024
Merged
Remove self._renderer from AnnotationBbox and ConnectionPatch#27806QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
As far as I can tell, these are unused, and cause problems for pickling Closes matplotlib#27805
timhoffm
approved these changes
Feb 20, 2024
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
I agree, that they seem unused.
QuLogic
approved these changes
Feb 21, 2024
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
i can't find any use for it either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
As far as I can tell, these are unused, and cause problems for pickling
Closes #27805
See #27805 (comment) for more details.
PR checklist