MNT: remove draw method args and kwargs #27819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
force-pushed
the
draw-args-kwargs
branch
from
b41642e
to
8526027
Compare
rcomer
force-pushed
the
draw-args-kwargs
branch
from
8526027
to
128fe0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist
Follow up to #27768, because I believe my understanding has improved: these methods both have the
allow_rasterizationdecorator, and that decorator has not passed args and kwargs since #20331. So you already can't pass any extra parameters here and therefore there is nothing to be gained by either a deprecation period or a release note.