Simplify the LineCollection example#27873
Merged
tacaswell merged 1 commit intomatplotlib:mainfrom Mar 14, 2024
Merged
Conversation
Member
Author
|
Preview: Plot 1: Plot 2: |
1 task
timhoffm
force-pushed
the
doc-linecollection-simple
branch
2 times, most recently
from
b56476f to
c42c055
Compare
ianhi
approved these changes
Mar 7, 2024
Contributor
ianhi
left a comment
ianhi
left a comment
There was a problem hiding this comment.
This is a significant improvement over the previous example.
regarding the masked arrays, that's a bit of a specialized use case, and (i think) linecollections aren't the only place where masked arrays are relevant. If keeping an example of masked arrays is important then perhaps a new "Using masked data" example would be best
timhoffm
force-pushed
the
doc-linecollection-simple
branch
2 times, most recently
from
257d02b to
24b0efa
Compare
QuLogic
reviewed
Mar 8, 2024
timhoffm
force-pushed
the
doc-linecollection-simple
branch
from
24b0efa to
a131488
Compare
Superseeds matplotlib#27871. This example is much simpler, but conveys the same LineCollection aspects - except for not using masked arrays. But I argue that this the example should be simple and using masked arrays rather distracts from the core aspects of LineCollection. If there's concern of not showing masked array support, we should add a third plot for that.
tacaswell
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseeds #27871.
This example is much simpler, but conveys the same LineCollection aspects - except for not using masked arrays. But I argue that this the example should be simple and using masked arrays rather distracts from the core aspects of LineCollection.
If there's concern of not showing masked array support, we should add a third plot for that.