Fix build on older macOS deployment targets#27883
Merged
ksunden merged 1 commit intomatplotlib:mainfrom Mar 12, 2024
Merged
Conversation
Apparently, macOS incorrectly hides this `std::optional.value` method behind the deployment target, even though it's a header-only implementation, so it shouldn't have any runtime requirement. Instead of fiddling with deployment targets, use an alternate method for getting the `std::optional` value.
github-actions
bot
added
topic: path handling
and removed
CI: Run cibuildwheel
tacaswell
approved these changes
Mar 11, 2024
Member
|
To check my understanding we only see this in the cibuildwheel job because we force back to an older target, where as with the normal mac CI jobs we let it build with what ever the latest and greatest it has available? |
Member
Author
|
Yea, that should be the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Apparently, macOS incorrectly hides this
std::optional.valuemethod behind the deployment target, even though it's a header-only implementation, so it shouldn't have any runtime requirement.Instead of fiddling with deployment targets, use an alternate method for getting the
std::optionalvalue.PR checklist