MNT: Remove remaining 3.7 deprecations#27968
Merged
dstansby merged 1 commit intomatplotlib:mainfrom Mar 24, 2024
Merged
Conversation
QuLogic
force-pushed
the
remove-3.7-deprecations
branch
from
a48a1d8 to
6aebd88
Compare
rcomer
previously approved these changes
Mar 23, 2024
Member
rcomer
left a comment
rcomer
left a comment
There was a problem hiding this comment.
The PR number in the changenote filename is 2 out but otherwise this looks good to me.
rcomer
reviewed
Mar 23, 2024
Not sure why I missed listing these in matplotlib#26865.
QuLogic
force-pushed
the
remove-3.7-deprecations
branch
from
6aebd88 to
a78a3d8
Compare
Member
|
Looks like Appveyor is running out of time? I re-started it but same result. |
rcomer
approved these changes
Mar 23, 2024
Member
rcomer
left a comment
rcomer
left a comment
There was a problem hiding this comment.
I will leave it to second reviewer to decide if the Appveyor failure matters, but I suspect it does not.
dstansby
approved these changes
Mar 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Not sure why I missed listing these in #26865.
PR checklist