Respect vertical_axis when rotating plot interactively#28039
Merged
QuLogic merged 5 commits intomatplotlib:mainfrom May 1, 2024
Merged
Respect vertical_axis when rotating plot interactively#28039QuLogic merged 5 commits intomatplotlib:mainfrom
QuLogic merged 5 commits intomatplotlib:mainfrom
Conversation
scottshambaugh
approved these changes
Apr 13, 2024
Contributor
scottshambaugh
left a comment
scottshambaugh
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for catching this! Not sure if a bugfix warrants a what's new, but not a big deal either way.
Member
|
Bug fixes usually do not get a "What's new", so if you remove that I'd be happy to merge this. Thanks! (Edit: as this was introduced in 3.8, I suggest to backport to 3.9. |
Contributor
|
You'll have to rebase squash your commits to pass the PR cleanliness check, but I think the other CI failures are unrelated. |
Contributor
Author
|
I don't know how to do that. |
Contributor
|
That works as well! We need a second maintainer to approve the PR before it can be merged, but I or them can squash merge it. |
QuLogic
approved these changes
May 1, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 1, 2024
…t interactively
QuLogic
added a commit
that referenced
this pull request
May 4, 2024
…039-on-v3.9.x Backport PR #28039 on branch v3.9.x (Respect vertical_axis when rotating plot interactively)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
In #25821
view_initwas added inax._on_movewithout all the arguments. This meant that the initial plot looked as intended withvertical_axis="x", but once the plot was rotated interactively thevertical_axiswas reset back to the default position.PR checklist