Skip to content

Clarify that findfont & _find_fonts_by_props return paths.#28078

Merged
tacaswell merged 1 commit intomatplotlib:mainfrom
anntzer:ffd
Apr 15, 2024
Merged

Clarify that findfont & _find_fonts_by_props return paths.#28078
tacaswell merged 1 commit intomatplotlib:mainfrom
anntzer:ffd

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Apr 15, 2024

Especially the previous wording for _find_fonts_by_props ("find font families") was somewhat confusing, as "font families" are strings.

PR summary

PR checklist

Especially the previous wording for _find_fonts_by_props ("find font
families") was somewhat confusing, as "font families" are strings.
Copy link
Copy Markdown
Member

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how it should be milestoned in these release times, but apart from that looks good! (If you know, @anntzer, milestone and self-merge.)

@tacaswell tacaswell added this to the v3.9.0 milestone Apr 15, 2024
@tacaswell tacaswell merged commit 83b07d4 into matplotlib:main Apr 15, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 15, 2024
@anntzer anntzer deleted the ffd branch April 15, 2024 13:49
ksunden added a commit that referenced this pull request Apr 17, 2024
…078-on-v3.9.x

Backport PR #28078 on branch v3.9.x (Clarify that findfont & _find_fonts_by_props return paths.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants