ci: Re-add tests with optimization enabled #29549
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It seems to have timed out; I suspect that it's one of the backend tests that I don't have the library for, which isn't running |
Member
Author
|
I made some changes to ensure that |
Also, skip a few tests that only work with docstrings enabled. Fixes matplotlib#10312
The jobs matrix doesn't set any environment variables, so the without-LTO job just set `CFLAGS` in the matrix, which was never used for anything as intended.
This means that: 1. assertion failures look a little better 2. assertions actually happen if optimization is enabled
It doesn't seem to support it, and is not really updated by upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Note that a few tests require skips, as they check for docstrings.
This PR also fixes testing with LTO disabled (it previously just set a variable in the matrix and did nothing with it.)
Fixes #10312
PR checklist