Fix location of QFontMetrics import #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is some obnoxious thing where different versions of Qt do things differently, right? How did you test it? |
Contributor
Author
|
I didn't, except on my computer. Thus the suspicion that it *may* work,
since it was based off of a tip by Thom Caswell.
…On 29 August 2017 1:23:43 PM "Nathaniel J. Smith" ***@***.***> wrote:
This is some obnoxious thing where different versions of Qt do things
differently, right? How did you test it?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#33 (comment)
|
Contributor
|
Ah, so we have someone to blame if it doesn't work? Sweet, good enough for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address #23