Skip to content

Add dev dependency group for easier local testing#87

Merged
mfisher87 merged 3 commits into
matplotlib:mainfrom
mfisher87:add-dev-deps-group
Jun 2, 2026
Merged

Add dev dependency group for easier local testing#87
mfisher87 merged 3 commits into
matplotlib:mainfrom
mfisher87:add-dev-deps-group

Conversation

@mfisher87
Copy link
Copy Markdown
Collaborator

Picking this repo back up to review #86 and needed this.

@mfisher87 mfisher87 requested a review from stefanv June 2, 2026 19:01
@mfisher87 mfisher87 marked this pull request as draft June 2, 2026 19:02
# Project dependencies + test dependencies from pyproject.toml
# NOTE: Also builds viscm. How do we avoid this?
pip install .
pip install --group dev . ${{ matrix.pyqt-dependency }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do base dependencies always come along?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I.e. these dependencies of viscm? Yeah, they come along with .!

dependencies = [
  "numpy ~=1.22",
  "matplotlib ~=3.5",
  "colorspacious ~=1.1",
  "scipy ~=1.8",
]

This reminds me I was just reading this comment you made over in a related issue :)

@mfisher87 mfisher87 marked this pull request as ready for review June 2, 2026 20:45
@mfisher87 mfisher87 merged commit ea058dc into matplotlib:main Jun 2, 2026
1 of 7 checks passed
@mfisher87 mfisher87 deleted the add-dev-deps-group branch June 2, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants