feat: add change_password pushers test #147

meenal06 · 2021-07-03T10:55:40Z

No description provided.

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

meenal06 · 2021-07-03T10:56:39Z

Hi @kegsay any idea why I am getting 404 on the pushers/set endpoint 😕 ?

=== CONT  TestChangePassword/Pushers_created_with_a_different_access_token_are_deleted_on_password_change
    account_change_password_test.go:123: MatchResponse got status 404 want 200 - http://localhost:55058/_matrix/client/r0/pushers/set => 404 page not found
2021/07/03 16:19:32 ============================================


2021/07/03 16:19:32 528d8bc2fe8a1f7124c4e8549e5fc1d4991ac4bc9b2f2b21c65cb9cb31935f18 : Server logs:
time="2021-07-03T10:49:31.997154700Z" level=info msg="Dendrite version 0.3.11" func="NewBaseDendrite\n\t" file=" [/build/setup/base.go:112]"
time="2021-07-03T10:49:32.039419700Z" level=info msg="Enabling MSC" func="Enable\n\t" file=" [/build/setup/mscs/mscs.go:31]" context=missing msc=msc2836
time="2021-07-03T10:49:32.042551600Z" level=info msg="Enabling MSC" func="Enable\n\t" file=" [/build/setup/mscs/mscs.go:31]" context=missing msc=msc2946
time="2021-07-03T10:49:32.044654400Z" level=info msg="Enabling MSC" func="Enable\n\t" file=" [/build/setup/mscs/mscs.go:31]" context=missing msc=msc2444
time="2021-07-03T10:49:32.047311700Z" level=info msg="Enabling MSC" func="Enable\n\t" file=" [/build/setup/mscs/mscs.go:31]" context=missing msc=msc2753
time="2021-07-03T10:49:32.050819800Z" level=info msg="Starting external Monolith listener on :8008" func="func2\n\t" file=" [/build/setup/base.go:427]"
time="2021-07-03T10:49:32.051471900Z" level=info msg="Starting external Monolith listener on :8448" func="func2\n\t" file=" [/build/setup/base.go:427]"
time="2021-07-03T10:49:32.103925300Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=lQzvwoH8SHQD req.method=GET req.path=/_matrix/client/versions
time="2021-07-03T10:49:32.104470400Z" level=trace msg="Responding (203 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=lQzvwoH8SHQD req.method=GET req.path=/_matrix/client/versions
time="2021-07-03T10:49:32.110632800Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=q7rIl8IpLzpR req.method=POST req.path=/_matrix/client/r0/register
time="2021-07-03T10:49:32.111287900Z" level=info msg="Processing registration request" func="Register\n\t" file=" [/build/clientapi/routing/register.go:526]" auth.type=m.login.dummy req.id=q7rIl8IpLzpR req.method=POST req.path=/_matrix/client/r0/register session_id="" username=test_change_password_user
time="2021-07-03T10:49:32.121604000Z" level=info msg=PerformDeviceCreation func="PerformDeviceCreation\n\t" file=" [/build/userapi/internal/api.go:115]" device_id="<nil>" display_name="<nil>" localpart=test_change_password_user req.id=q7rIl8IpLzpR req.method=POST req.path=/_matrix/client/r0/register
time="2021-07-03T10:49:32.134324700Z" level=info msg="Sending device list update message to []" func="onMessage\n\t" file=" [/build/federationsender/consumers/keychange.go:132]"
time="2021-07-03T10:49:32.139230800Z" level=info msg="Produced to key change topic 'DendriteOutputKeyChangeEvent'" func="ProduceKeyChanges\n\t" file=" [/build/keyserver/producers/keychange.go:72]" num_key_changes=1 user_id="@test_change_password_user:hs1"
time="2021-07-03T10:49:32.139684300Z" level=trace msg="Responding (148 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=q7rIl8IpLzpR req.method=POST req.path=/_matrix/client/r0/register
time="2021-07-03T10:49:32.142531900Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=BwXcMlGSkU1I req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.145587200Z" level=info msg=PerformDeviceCreation func="PerformDeviceCreation\n\t" file=" [/build/userapi/internal/api.go:115]" device_id="<nil>" display_name="<nil>" localpart=test_change_password_user req.id=BwXcMlGSkU1I req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.156759100Z" level=info msg="Sending device list update message to []" func="onMessage\n\t" file=" [/build/federationsender/consumers/keychange.go:132]"
time="2021-07-03T10:49:32.165801300Z" level=info msg="Produced to key change topic 'DendriteOutputKeyChangeEvent'" func="ProduceKeyChanges\n\t" file=" [/build/keyserver/producers/keychange.go:72]" num_key_changes=1 user_id="@test_change_password_user:hs1"
time="2021-07-03T10:49:32.166919600Z" level=trace msg="Responding (148 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=BwXcMlGSkU1I req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.169855500Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=VuHhPjyvGirD req.method=POST req.path=/_matrix/client/r0/account/password
time="2021-07-03T10:49:32.176794600Z" level=info msg=PerformDeviceDeletion func="PerformDeviceDeletion\n\t" file=" [/build/userapi/internal/api.go:127]" devices="[]" req.id=VuHhPjyvGirD req.method=POST req.path=/_matrix/client/r0/account/password user_id="@test_change_password_user:hs1"
time="2021-07-03T10:49:32.186350500Z" level=info msg="Sending device list update message to []" func="onMessage\n\t" file=" [/build/federationsender/consumers/keychange.go:132]"
time="2021-07-03T10:49:32.193333400Z" level=info msg="Produced to key change topic 'DendriteOutputKeyChangeEvent'" func="ProduceKeyChanges\n\t" file=" [/build/keyserver/producers/keychange.go:72]" num_key_changes=1 user_id="@test_change_password_user:hs1"
time="2021-07-03T10:49:32.193726500Z" level=trace msg="Responding (2 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=VuHhPjyvGirD req.method=POST req.path=/_matrix/client/r0/account/password
time="2021-07-03T10:49:32.196225300Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=1ma1hVLsumaC req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.197941900Z" level=trace msg="Responding (101 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=403 req.id=1ma1hVLsumaC req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.201223500Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=KcgSZM1kL9Rc req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.202740900Z" level=info msg=PerformDeviceCreation func="PerformDeviceCreation\n\t" file=" [/build/userapi/internal/api.go:115]" device_id="<nil>" display_name="<nil>" localpart=test_change_password_user req.id=KcgSZM1kL9Rc req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.214354200Z" level=info msg="Sending device list update message to []" func="onMessage\n\t" file=" [/build/federationsender/consumers/keychange.go:132]"
time="2021-07-03T10:49:32.221509600Z" level=info msg="Produced to key change topic 'DendriteOutputKeyChangeEvent'" func="ProduceKeyChanges\n\t" file=" [/build/keyserver/producers/keychange.go:72]" num_key_changes=1 user_id="@test_change_password_user:hs1"
time="2021-07-03T10:49:32.221934400Z" level=trace msg="Responding (148 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=KcgSZM1kL9Rc req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.224896600Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=8R3qLqXlQhqW req.method=GET req.path=/_matrix/client/r0/account/whoami
time="2021-07-03T10:49:32.225665100Z" level=trace msg="Responding (44 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=8R3qLqXlQhqW req.method=GET req.path=/_matrix/client/r0/account/whoami
time="2021-07-03T10:49:32.228592300Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=yzuT5E7TvpZh req.method=GET req.path=/_matrix/client/r0/account/whoami
time="2021-07-03T10:49:32.229025800Z" level=trace msg="Responding (53 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=401 req.id=yzuT5E7TvpZh req.method=GET req.path=/_matrix/client/r0/account/whoami
time="2021-07-03T10:49:32.231439200Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=7uU1t0BRg52H req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.234044600Z" level=info msg=PerformDeviceCreation func="PerformDeviceCreation\n\t" file=" [/build/userapi/internal/api.go:115]" device_id="<nil>" display_name="<nil>" localpart=test_change_password_user req.id=7uU1t0BRg52H req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.245347700Z" level=info msg="Sending device list update message to []" func="onMessage\n\t" file=" [/build/federationsender/consumers/keychange.go:132]"
time="2021-07-03T10:49:32.252479000Z" level=info msg="Produced to key change topic 'DendriteOutputKeyChangeEvent'" func="ProduceKeyChanges\n\t" file=" [/build/keyserver/producers/keychange.go:72]" num_key_changes=1 user_id="@test_change_password_user:hs1"
time="2021-07-03T10:49:32.253316800Z" level=trace msg="Responding (148 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=7uU1t0BRg52H req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.256321500Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=lFH7fgezSRBf req.method=POST req.path=/_matrix/client/r0/account/password
time="2021-07-03T10:49:32.264958900Z" level=trace msg="Responding (2 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=lFH7fgezSRBf req.method=POST req.path=/_matrix/client/r0/account/password
time="2021-07-03T10:49:32.267574500Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=RRHt3wG8Tz0U req.method=GET req.path=/_matrix/client/r0/account/whoami
time="2021-07-03T10:49:32.268029400Z" level=trace msg="Responding (44 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=RRHt3wG8Tz0U req.method=GET req.path=/_matrix/client/r0/account/whoami
time="2021-07-03T10:49:32.270721800Z" level=trace msg="Incoming request" func="RequestWithLogging\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:123]" req.id=6ofJVo8dMN8G req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.273331100Z" level=info msg=PerformDeviceCreation func="PerformDeviceCreation\n\t" file=" [/build/userapi/internal/api.go:115]" device_id="<nil>" display_name="<nil>" localpart=test_change_password_user req.id=6ofJVo8dMN8G req.method=POST req.path=/_matrix/client/r0/login
time="2021-07-03T10:49:32.285417100Z" level=info msg="Sending device list update message to []" func="onMessage\n\t" file=" [/build/federationsender/consumers/keychange.go:132]"
time="2021-07-03T10:49:32.294458200Z" level=info msg="Produced to key change topic 'DendriteOutputKeyChangeEvent'" func="ProduceKeyChanges\n\t" file=" [/build/keyserver/producers/keychange.go:72]" num_key_changes=1 user_id="@test_change_password_user:hs1"
time="2021-07-03T10:49:32.294922000Z" level=trace msg="Responding (148 bytes)" func="respond\n\t" file=" [/go/pkg/mod/github.com/matrix-org/util@v0.0.0-20200807132607-55161520e1d4/json.go:173]" code=200 req.id=6ofJVo8dMN8G req.method=POST req.path=/_matrix/client/r0/login
2021/07/03 16:19:32 ============== 528d8bc2fe8a1f7124c4e8549e5fc1d4991ac4bc9b2f2b21c65cb9cb31935f18 : END LOGS ==============

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

meenal06 · 2021-07-03T11:01:27Z

@kegsay never mind looks like the pushers endpoint is not implemented in the Dendrite homeserver

kegsay

Please move these tests into a new file tests/account_change_password_pushers_test.go and then add a blacklist build tag for Dendrite. Thanks!

tests/account_change_password_test.go

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

tests/account_change_password_test.go

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

meenal06 · 2021-07-08T17:22:32Z

@kegsay please review, I have done all the requested changes !

kegsay · 2021-07-09T07:47:04Z

tests/account_change_password_pushers_test.go

+				match.JSONKeyPresent("pushers"),
+				match.JSONArrayEach("pushers", func(val gjson.Result) error {
+					if len(val.Array()) != 0 {
+						return fmt.Errorf("expected array length to be zero: %v", val.Raw)


You need to do the same trick here with pushersSize++.

meenal06 · 2021-07-10T07:20:56Z

@kegsay please merge

tests/account_change_password_pushers_test.go

meenal06 added 2 commits July 3, 2021 16:22

feat: add change_password pushers test:

7dc7a75

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

fix

fb4af3e

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

password fix

2bc14b0

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

kegsay requested changes Jul 5, 2021

View reviewed changes

meenal06 added 2 commits July 6, 2021 00:06

fix

85acba8

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

fix

5931f5b

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

meenal06 force-pushed the pushers_pw branch from facc29c to 5931f5b Compare July 5, 2021 19:51

fix

395820f

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

meenal06 requested a review from kegsay July 6, 2021 13:27

kegsay reviewed Jul 7, 2021

View reviewed changes

tests/account_change_password_test.go Outdated Show resolved Hide resolved

fix

181976a

Signed-off-by: Meenal Trivedi <meenaltrivedi6102@gmail.com>

meenal06 requested a review from kegsay July 8, 2021 17:22

kegsay reviewed Jul 9, 2021

View reviewed changes

kegsay approved these changes Jul 9, 2021

View reviewed changes

meenal06 added 2 commits July 10, 2021 12:46

Update account_change_password_pushers_test.go

87c64f7

Update account_change_password_pushers_test.go

56c3d85

meenal06 requested a review from kegsay July 10, 2021 07:20

kegsay reviewed Jul 12, 2021

View reviewed changes

tests/account_change_password_pushers_test.go Outdated Show resolved Hide resolved

Update tests/account_change_password_pushers_test.go

13bb398

kegsay reviewed Jul 12, 2021

View reviewed changes

tests/account_change_password_pushers_test.go Outdated Show resolved Hide resolved

Update tests/account_change_password_pushers_test.go

4a1a243

kegsay merged commit adae8c1 into matrix-org:master Jul 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add change_password pushers test #147

feat: add change_password pushers test #147

Uh oh!

meenal06 commented Jul 3, 2021

Uh oh!

meenal06 commented Jul 3, 2021

Uh oh!

meenal06 commented Jul 3, 2021 •

edited

Loading

Uh oh!

kegsay left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

meenal06 commented Jul 8, 2021

Uh oh!

kegsay Jul 9, 2021 •

edited

Loading

Uh oh!

meenal06 commented Jul 10, 2021

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: add change_password pushers test #147

feat: add change_password pushers test #147

Uh oh!

Conversation

meenal06 commented Jul 3, 2021

Uh oh!

meenal06 commented Jul 3, 2021

Uh oh!

meenal06 commented Jul 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kegsay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

meenal06 commented Jul 8, 2021

Uh oh!

kegsay Jul 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meenal06 commented Jul 10, 2021

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

meenal06 commented Jul 3, 2021 •

edited

Loading

kegsay Jul 9, 2021 •

edited

Loading