Re-sort the sytest.list #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While addressing #270 with a newer sytest commit, I realised that the original
sortwas not as deterministic as I thought it would be, and that macOSsortacted differently than GNUsort, and GNUsortitself could act differently depending on set locale.So, to remedy this, and to prepare for the update for the sytest list, I re-sorted it again and made the command work with a fixed linux distro + version, together with a specific locale, as that determined the sort as well.
This was performed on the same commit, there should be no new tests added, only shuffled around.
After this PR, I will make another one that will close update the list to the latest sytest commit, which will the #270 issue, as then most of the concerns have been addressed.
This PR is done separately from the above one to make sure irrelevant shuffling will not mix with the list update, and so that the update (and test additions/removals) can be addressed on their own.