Stop testing unspecced POST /send#850
Conversation
Signed-off-by: Tulir Asokan <tulir@maunium.net>
|
Not sure what that test failure is 🤔 |
complement/.github/workflows/ci.yaml Line 121 in 12210e3 (I fixed this in a repo somewhere to prevent this obtuse error from shadowing the real one, but currently failing to find it or the solution...) |
This reverts commit ce4bdcd.
.github/workflows/ci.yaml
Outdated
| - run: | | ||
| set -o pipefail && | ||
| ${{ matrix.env }} go test -v -json -tags "${{ matrix.tags }}" -timeout "${{ matrix.timeout }}" ./tests ./tests/csapi ${{ matrix.packages }} | .ci/scripts/gotestfmt | ||
| ${{ matrix.env }} go test -v -json -tags "${{ matrix.tags }}" -timeout "${{ matrix.timeout }}" ./tests ./tests/csapi ${{ matrix.packages }} # | .ci/scripts/gotestfmt |
There was a problem hiding this comment.
panic: BUG: Empty package name encountered.will occur whengotestfmtreceives an error and isn't able to parse the output. Try temporarily removing| .ci/scripts/gotestfmtfrom the following line in CI:
We did this in Synapse for example, element-hq/synapse#19326
|
It was just a compile error, tests should pass now |
tests/csapi/invalid_test.go
Outdated
| for _, testCase := range testCases { | ||
| res := alice.Do(t, "POST", []string{"_matrix", "client", "v3", "rooms", roomID, "send", "complement.dummy"}, client.WithJSONBody(t, testCase)) | ||
| for i, testCase := range testCases { | ||
| res := alice.Do(t, "PUT", []string{"_matrix", "client", "v3", "rooms", roomID, "send", "complement.dummy", fmt.Sprintf("invalidnum-%d", i)}, client.WithJSONBody(t, testCase)) |
There was a problem hiding this comment.
Spec for reference: PUT /_matrix/client/v3/rooms/{roomId}/send/{eventType}/{txnId}
MadLittleMods
left a comment
MadLittleMods
left a comment
There was a problem hiding this comment.
Looks good, just a few clean-up items
The txn send endpoint is tested below, so TestSendAndFetchMessage is only relevant for testing /messages
|
Thanks for cleaning up the test suite @tulir 🐻❄️ |
3 participants
For element-hq/synapse#19557