Update Synapse quarantine fetching to use new API#10
Merged
Conversation
Member
Author
|
Requires #9 for CI checks |
H-Shay
reviewed
Mar 17, 2026
H-Shay
left a comment
H-Shay
left a comment
There was a problem hiding this comment.
Seems fine, but wondering if you want to wait to merge it until the API it relies on is approved/merged?
Member
Author
|
Ideally we wouldn't have landed the first one, but we're here now. I think it's best to land this to unbreak the "feature" and return this to a releaseable state. The changes to the README should give us enough leeway if the Synapse PR gets rejected or changes (again), hopefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires element-hq/synapse#19558 per readme changes (the prior PR should have been documented)