Skip to content

Revert "only start with a timeline reset diff if the timeline isn't empty"#6599

Merged
poljar merged 1 commit into
mainfrom
ganfra/timeline_initial_loading
May 21, 2026
Merged

Revert "only start with a timeline reset diff if the timeline isn't empty"#6599
poljar merged 1 commit into
mainfrom
ganfra/timeline_initial_loading

Conversation

@ganfra
Copy link
Copy Markdown
Contributor

@ganfra ganfra commented May 20, 2026

Revert #6380 (but partially keep the updated comment)

  • I've documented the public API changes in the appropriate changelog files
    (see Writing changelog entries).
  • This PR was made with the help of AI.

Signed-off-by:

@ganfra ganfra requested a review from a team as a code owner May 20, 2026 18:55
@ganfra ganfra requested review from poljar and removed request for a team May 20, 2026 18:55
@ganfra ganfra force-pushed the ganfra/timeline_initial_loading branch from 969d2cb to 0cfa07d Compare May 20, 2026 19:00
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.96%. Comparing base (82c24a8) to head (0cfa07d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6599      +/-   ##
==========================================
- Coverage   89.96%   89.96%   -0.01%     
==========================================
  Files         382      382              
  Lines      107941   107941              
  Branches   107941   107941              
==========================================
- Hits        97112    97105       -7     
+ Misses       7168     7166       -2     
- Partials     3661     3670       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 20, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing ganfra/timeline_initial_loading (0cfa07d) with main (82c24a8)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add a bit more clarity why this is getting reverted. The applications prefer the previos API shape so let us give the people what they want.

@poljar poljar enabled auto-merge (rebase) May 21, 2026 07:24
@poljar poljar merged commit 4ca424f into main May 21, 2026
60 of 61 checks passed
@poljar poljar deleted the ganfra/timeline_initial_loading branch May 21, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants