SCSS revamp #2364
Closed
SCSS revamp #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-website with
|
| Latest commit: |
39ea971
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c8866ac.matrix-website.pages.dev |
| Branch Preview URL: | https://mtrnord-scss-revamp-v0.matrix-website.pages.dev |
The underscore denotes partials in sass which means they are not "entrypoints". This also means the underscore in imports is not meant to be used and instead it should just be refered to their "component" name.
…call-to-action
…to use the helper variables
MTRNord
force-pushed
the
MTRNord/scss_revamp_v0
branch
from
144299d to
9767af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cleanup of our scss codebase. Moving things out of files into component files, migrating to the more modern import syntax using
@useinstead of@importand applying some modernizing settings from stylelint.The commits are made in a way where reviewing commit by commit should be possible