Support @mscbot commands in PR review bodies#26
Merged
anoadragon453 merged 2 commits intomasterfrom Nov 22, 2022
Merged
Conversation
This is the text that appears as part of a PR review (not the one or more comments on the actual diff of the changes.
erikjohnston
approved these changes
Jul 25, 2022
Member
Author
|
Have finally tested this manually - and it works 🎉 (This repo is overdue for automated tests.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the text that appears as part of a PR review (not the one or more comments on the actual diff of the changes). For example specifying commands like so would now work.
This also requires updating your webhook settings to now include "Pull request reviews". This has already been done for matrix-org/matrix-spec-proposals.