Replaced buggy is-utf8 with utf-8-validate library #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmari
suggested changes
Jun 17, 2020
lib/irc.js
Outdated
| if (!isUtf8(str)) { | ||
| const converter = new Iconv(self.opt.encodingFallback, "UTF-8") | ||
| if (!isValidUTF8(str)) { | ||
| const converter = new Iconv(self.opt.encodingFallback[0], "UTF-8") |
There was a problem hiding this comment.
Did you mean to change this to treating encodingFallback as an array? It's defined as a string in matrix-appservice-irc.
Author
There was a problem hiding this comment.
Hm, I suppose not. Need to check that again.
|
@vranki ping? Also, the CI build is failing:
|
Author
|
I'm on a business trip so can't do much right now. Anyone is free to make the required changes based on this pr. |
Half-Shot
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix issues with CTCP actions containing ASCII control codes.
On my test setup there is no more false re-encoding for utf-8 actions like with is-utf8 library.
I suggest a new release to npm after this to get the fix usable in Matrix IRC bridge. At least
IRCnet bridge suffers from the encoding bugs.