Skip to content

Replaced buggy is-utf8 with utf-8-validate library #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Replaced buggy is-utf8 with utf-8-validate library #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94b55a5
Replaced buggy is-utf8 with utf-8-validate library
vranki Jun 17, 2020
75d41a2
Changes suggested in PR #49. Tested working locally.
vranki Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/irc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const dns = require('dns');
const net = require('net');
const tls = require('tls');
const util = require('util');
const isUtf8 = require('is-utf8');
const isValidUTF8 = require('utf-8-validate');
const { EventEmitter } = require('events');

const colors = require('./colors');
Expand Down Expand Up @@ -1286,7 +1286,7 @@ Client.prototype.convertEncoding = function(str) {
}
} else if (self.opt.encodingFallback) {
try {
if (!isUtf8(str)) {
if (!isValidUTF8(str)) {
const converter = new Iconv(self.opt.encodingFallback, "UTF-8")
out = converter.convert(str)
}
Expand Down
13 changes: 13 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"irc-colors": "^1.1.0",
"rebuild": "^0.1.2",
"is-utf8": "^0.2.1"
"utf-8-validate": "^5.0.2"
},
"optionalDependencies": {
"iconv": "~2.3.4",
Expand Down