Skip to content

Add type-safe accessor for the logger #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kegsay merged 5 commits into from
Feb 20, 2017
Merged

Add type-safe accessor for the logger #2

kegsay merged 5 commits into from
Feb 20, 2017

Conversation

@kegsay
Copy link
Member

@kegsay kegsay commented Feb 20, 2017

No description provided.

@coveralls
Copy link

coveralls commented Feb 20, 2017

Coverage Status

Coverage decreased (-4.8%) to 80.189% when pulling bb66103 on kegan/ctx-typesafe-access into 0f4d9cc on master.

@kegsay kegsay mentioned this pull request Feb 20, 2017
Merged
@NegativeMjark
Copy link
Contributor

NegativeMjark commented Feb 20, 2017 •
edited
Loading

This looks good. Ideally we'd also hide the ContextKeys type so that other modules can't set the wrong type of logger into the context.

NegativeMjark
NegativeMjark reviewed Feb 20, 2017
View reviewed changes
json.go Outdated
type ContextKeys string

// CtxValueLogger is the key to extract the logrus Logger.
const CtxValueLogger = ContextKeys("logger")
Copy link
Contributor

@NegativeMjark NegativeMjark Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the ContextKeys type and the CtxValueLogger const private?

Copy link
Member Author

@kegsay kegsay Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

NegativeMjark
NegativeMjark suggested changes Feb 20, 2017
View reviewed changes
Copy link
Contributor

@NegativeMjark NegativeMjark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd like us to hide the Context keys here.

@kegsay
Copy link
Member Author

kegsay commented Feb 20, 2017

@NegativeMjark PTAL

@kegsay kegsay mentioned this pull request Feb 20, 2017
Merged
NegativeMjark
NegativeMjark approved these changes Feb 20, 2017
View reviewed changes
Copy link
Contributor

@NegativeMjark NegativeMjark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kegsay kegsay merged commit 4c35914 into master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NegativeMjark NegativeMjark NegativeMjark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NegativeMjark NegativeMjark

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kegsay @coveralls @NegativeMjark