test: remove bvt skip flags for dtype and function tests by flypiggyyoyoyo · Pull Request #23657 · matrixorigin/matrixone

flypiggyyoyoyo · 2026-02-03T08:16:21Z

User description

What type of PR is this?

Which issue(s) this PR fixes:

issue #23658

What this PR does / why we need it:

Remove @bvt:issue tags for fixed issues:

[Bug]: Implicit conversion failed from VARCHAR to INT #3276 (int.test)
[Bug]: Implicit conversion failed from DOUBLE to DECIMAL #3280, [Bug]: Data truncation failed for decimal #3364, [Enhancement]: Decimal64 and Decimal128 in C #4241, [Bug]: The division of decimal #8513 (numeric.sql, decimal.test)
[Bug]: long double number lost precision #3579 (func_anyvalue.test)
[Bug]: Data errors cause bvt failure #7589 (text_blob.sql)
Support the year type #23408 (year.sql)

PR Type

Tests

Description

Remove @bvt:issue skip tags from resolved test cases
Covers dtype tests (decimal, numeric, int, text_blob, year)
Covers function tests (func_anyvalue)
Issues fixed: [Bug]: Implicit conversion failed from VARCHAR to INT #3276, [Bug]: Implicit conversion failed from DOUBLE to DECIMAL #3280, [Bug]: Data truncation failed for decimal #3364, [Enhancement]: Decimal64 and Decimal128 in C #4241, [Bug]: Data errors cause bvt failure #7589, [Bug]: The division of decimal #8513, Support the year type #23408

Diagram Walkthrough

flowchart LR
  A["Test Files with @bvt:issue Tags"] -- "Remove skip annotations" --> B["Clean Test Cases"]
  B -- "Issues: #3276, #3280, #3364, #4241, #7589, #8513, #23408" --> C["Tests Ready for BVT Execution"]

File Walkthrough

Relevant files

Tests

decimal.test `Remove BVT skip tags from decimal tests` test/distributed/cases/dtype/decimal.test Removed @bvt:issue#3364 tags (3 occurrences) for decimal overflow/precision tests Removed @bvt:issue#3280 tags (2 occurrences) for decimal comparison and update operations Removed @bvt:issue#4241 tag for decimal cast modulo operation Removed @bvt:issue#8513 tags (2 occurrences) for decimal division operations Removed standalone @bvt:issue tags (5 occurrences) marking test boundaries	+0/-17
numeric.sql `Remove BVT skip tags from numeric tests` test/distributed/cases/dtype/numeric.sql Removed @bvt:issue#3364 tags (3 occurrences) for numeric overflow/precision tests Removed @bvt:issue#3280 tags (2 occurrences) for numeric comparison and update operations Removed @bvt:issue#4241 tag for numeric cast modulo operation Removed @bvt:issue#8513 tags (2 occurrences) for numeric division operations Removed standalone @bvt:issue tags (5 occurrences) marking test boundaries	+0/-18
int.test `Remove BVT skip tags from int tests` test/distributed/cases/dtype/int.test Removed @bvt:issue#3276 tags (2 occurrences) for unsigned integer comparison tests Removed standalone @bvt:issue tags (2 occurrences) marking test boundaries	+0/-4
text_blob.sql `Remove BVT skip tags from text_blob tests` test/distributed/cases/dtype/text_blob.sql Removed @bvt:issue#7589 tag for text subquery comparison test Removed standalone @bvt:issue tag marking test boundary	+0/-2
year.sql `Remove BVT skip tags from year tests` test/distributed/cases/dtype/year.sql Removed @bvt:issue#23408 tags (2 occurrences) for year unique constraint violation test	+0/-2
func_anyvalue.test `Remove BVT skip tags from func_anyvalue tests` test/distributed/cases/function/func_anyvalue.test Removed @bvt:issue#3579 tag for any_value function extreme value test Removed standalone @bvt:issue tag marking test boundary	+0/-2

qodo-code-review · 2026-02-03T08:16:53Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance

🟢

No security concerns identified

No security vulnerabilities detected by AI analysis. Human verification advised for critical code.

Ticket Compliance

🟡

🎫 #3364

🔴	Fix the bug where inserting values into a `decimal(29,0)` primary key column (including hex literal like `0xFFFFFFFFFFFFFE` and high-precision decimal literals) incorrectly fails with "Data truncation: Incorrect DECIMAL128 value".

Codebase Duplication Compliance

⚪

Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance

🟢

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

qodo-code-review · 2026-02-03T08:17:07Z

PR Code Suggestions ✨

No code suggestions found for the PR.

mergify · 2026-02-06T02:19:20Z

Merge Queue Status

🚫 The pull request has left the queue (rule: main) at 18f2008

This pull request spent 13 minutes 7 seconds in the queue, with no time running CI.

Reason

The pull request #23657 has been manually updated

Hint

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

mergify · 2026-02-06T03:25:15Z

Merge Queue Status

🟠 Waiting for merge conditions (rule: main)

Entered the queue at: 2026-02-06 03:25 UTC.
Checks are running in-place (dashboard).
Merge ETA: 2026-02-06 04:18 UTC. Buckle up 🚀

Required conditions to merge

Required conditions to stay in the queue

add func+data

c1aa853

flypiggyyoyoyo requested a review from heni02 as a code owner February 3, 2026 08:16

Merge branch 'main' into bvt1

78be15d

qodo-code-review bot added the Review effort 2/5 label Feb 3, 2026

mergify bot added the kind/test-ci label Feb 3, 2026

flypiggyyoyoyo temporarily deployed to ci February 3, 2026 08:26 — with GitHub Actions Inactive

flypiggyyoyoyo had a problem deploying to ci February 3, 2026 08:26 — with GitHub Actions Failure

flypiggyyoyoyo temporarily deployed to ci February 3, 2026 08:26 — with GitHub Actions Inactive

matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Feb 3, 2026

Merge branch 'main' into bvt1

f419e5a

flypiggyyoyoyo temporarily deployed to ci February 3, 2026 09:33 — with GitHub Actions Inactive

flypiggyyoyoyo had a problem deploying to ci February 3, 2026 09:33 — with GitHub Actions Failure

flypiggyyoyoyo temporarily deployed to ci February 3, 2026 09:33 — with GitHub Actions Inactive

Merge branch 'main' into bvt1

49e7a66

flypiggyyoyoyo had a problem deploying to ci February 4, 2026 02:46 — with GitHub Actions Error

flypiggyyoyoyo temporarily deployed to ci February 5, 2026 13:29 — with GitHub Actions Inactive

heni02 approved these changes Feb 6, 2026

View reviewed changes

mergify bot added the queued label Feb 6, 2026

Merge branch 'main' into bvt1

e0446ed

flypiggyyoyoyo temporarily deployed to ci February 6, 2026 02:31 — with GitHub Actions Inactive

mergify bot added queued and removed queued labels Feb 6, 2026

Merge branch 'main' into bvt1

1dc6bbc

mergify bot temporarily deployed to ci February 6, 2026 03:25 Inactive

mergify bot requested a deployment to ci February 6, 2026 03:25 In progress

mergify bot temporarily deployed to ci February 6, 2026 03:25 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: remove bvt skip flags for dtype and function tests#23657

test: remove bvt skip flags for dtype and function tests#23657
flypiggyyoyoyo wants to merge 13 commits intomatrixorigin:mainfrom
flypiggyyoyoyo:bvt1

flypiggyyoyoyo commented Feb 3, 2026 •

edited

Loading

Uh oh!

qodo-code-review bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

qodo-code-review bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

mergify bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

mergify bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

flypiggyyoyoyo commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

What type of PR is this?

Which issue(s) this PR fixes:

What this PR does / why we need it:

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

qodo-code-review bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Compliance Guide 🔍

Uh oh!

qodo-code-review bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Uh oh!

mergify bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

flypiggyyoyoyo commented Feb 3, 2026 •

edited

Loading

qodo-code-review bot commented Feb 3, 2026 •

edited

Loading

qodo-code-review bot commented Feb 3, 2026 •

edited

Loading

mergify bot commented Feb 6, 2026 •

edited

Loading

mergify bot commented Feb 6, 2026 •

edited

Loading