fix: clear prepared binary param state#23984
Merged
mergify[bot] merged 3 commits intomatrixorigin:mainfrom Mar 28, 2026
Merged
Conversation
LeftHandCold
approved these changes
Mar 28, 2026
Contributor
Merge Queue Status
This pull request spent 55 minutes 49 seconds in the queue, with no time running CI. ReasonThe pull request can't be updated
HintYou should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align Test_ExecRequestStmtExecuteErrorClearsPreparedBinaryState with the current fix behavior: malformed COM_STMT_EXECUTE cleanup frees the params vector and clears the pointer, so the test must assert nil instead of dereferencing the released vector. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
XuPeng-SH
force-pushed
the
fix-prepare-param-growth
branch
from
8b2190b to
98f1d77
Compare
matrix-meow
added
size/S
Contributor
Merge Queue Status
This pull request spent 1 hour 50 minutes 16 seconds in the queue, including 55 minutes 57 seconds running CI. Required conditions to merge
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #23983
What this PR does / why we need it:
This PR reclaims prepared-statement binary parameter state after
COM_STMT_EXECUTEand on malformed execute cleanup.It fixes two closely related problems on
main:COM_STMT_EXECUTEpackets could leave a partially populated params vector attached to the prepared statement because the parse-error path dropped the statement pointer before cleanup.Focused validation:
go test ./pkg/frontend -run 'TestPrepareStmtClearBinaryParamStateReleasesParamArea|Test_ExecRequestStmtExecuteErrorClearsPreparedParamState'go test ./pkg/frontend -run 'TestPrepareStmtClearBinaryParamStateReleasesParamArea|Test_ExecRequestStmtExecuteErrorClearsPreparedParamState|Test_parseStmtSendLongData'