fix: allow '=' in object path for LOAD DATA#24021
Merged
mergify[bot] merged 4 commits intomatrixorigin:mainfrom Apr 1, 2026
Merged
fix: allow '=' in object path for LOAD DATA#24021mergify[bot] merged 4 commits intomatrixorigin:mainfrom
mergify[bot] merged 4 commits intomatrixorigin:mainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 4b84cb0)
There was a problem hiding this comment.
Pull request overview
Updates fileservice path validation to support object keys containing = (e.g., Hive-style k=v/ partitions) so LOAD DATA / external file reads won’t reject valid OSS/S3 paths.
Changes:
- Allow
=inParsePathfile component validation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@mergify requeue |
Contributor
Merge Queue Status
This pull request spent 57 minutes 31 seconds in the queue, including 57 minutes 18 seconds running CI. Required conditions to merge
|
Contributor
☑️ This pull request is already queued |
fengttt
pushed a commit
to fengttt/matrixone
that referenced
this pull request
May 7, 2026
### Problem - Allow `=` in fileservice path validation for LOAD DATA/external file paths. - This supports valid object keys such as `sjrq=20200504/...` on OSS/S3. ### Verification - Reproduced and fixed `ERROR 20411: invalid file path ...` for keys containing `=`. - Verified parquet load flow proceeds past path validation. Approved by: @XuPeng-SH
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #10162
What this PR does / why we need it:
Problem
=in fileservice path validation for LOAD DATA/external file paths.sjrq=20200504/...on OSS/S3.Verification
ERROR 20411: invalid file path ...for keys containing=.