Skip to content

feat: add JSON_LENGTH built-in function - #24469

Merged
mergify[bot] merged 13 commits into
matrixorigin:mainfrom
ULookup:feat/json-length
May 20, 2026
Merged

feat: add JSON_LENGTH built-in function#24469
mergify[bot] merged 13 commits into
matrixorigin:mainfrom
ULookup:feat/json-length

Conversation

@ULookup

@ULookup ULookup commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #23140

What this PR does / why we need it:

Add JSON_LENGTH(json_doc[, path]) built-in function, matching MySQL behavior:

  • object returns member count, array returns element count
  • scalar returns 1
  • JSON null literal and SQL NULL return NULL
  • path not found returns NULL
  • supports wildcard paths consistent with JSON_EXTRACT

Implementation follows the existing JSON function pattern (jsonExtract), including a dedicated jsonLengthCheckFn for argument validation and jsonLength operator for execution.

@qodo-code-review

qodo-code-review Bot commented May 19, 2026

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@CLAassistant

CLAassistant commented May 19, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@matrix-meow matrix-meow added the size/L Denotes a PR that changes [500,999] lines label May 19, 2026
@ULookup ULookup linked an issue May 19, 2026 that may be closed by this pull request
Text/JSON functions OCTET_LENGTH and JSON_LENGTH not supported #23140
Closed
ULookup added 8 commits May 19, 2026 01:28
@ULookup
feat: add JSON_LENGTH function ID and alias
824532b
@ULookup
feat: add jsonLengthCheckFn and jsonLength operator for JSON_LENGTH
82f3c5f
@ULookup
fix: TpCodeLiteral in jsonLength should return 1 not NULL
07ac66f
@ULookup
feat: register JSON_LENGTH in supportedStringBuiltIns
90c6a45
@ULookup
test: add unit tests for jsonLengthCheckFn
2e973c3
@ULookup
test: add missing checkFn branch coverage for jsonLengthCheckFn
490565e 
Add test cases for three previously untested branches:
- First arg that cannot cast to varchar (T_geometry) fails
- Second arg castable to varchar (T_int64) succeeds with cast
- Second arg not castable to varchar (T_geometry) fails
@ULookup
test: add operator unit tests and BVT tests for JSON_LENGTH
d7a5c57 
Coverage: all 14 edge cases including NULL, object/array counts,
scalar handling, boolean literals, path extraction, and error cases.
@ULookup
test: add invalid JSON and wildcard path coverage for JSON_LENGTH
1bd06d9
@ULookup
ULookup force-pushed the feat/json-length branch from 10e7054 to 1bd06d9 Compare May 19, 2026 08:29
@mergify mergify Bot added the queued label May 20, 2026
@mergify

mergify Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-05-20 08:25 UTC · Rule: main
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-05-20 08:25 UTC · at 18956a74a1a7b17c8efc04079af380e8e4574fd0 · squash

This pull request spent 25 seconds in the queue, including 5 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • github-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-neutral = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-skipped = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / SCA Test on Ubuntu/x86
    • check-neutral = Matrixone CI / SCA Test on Ubuntu/x86
    • check-skipped = Matrixone CI / SCA Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / UT Test on Ubuntu/x86
    • check-neutral = Matrixone CI / UT Test on Ubuntu/x86
    • check-skipped = Matrixone CI / UT Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-neutral = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-skipped = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = Matrixone Utils CI / Coverage
    • check-neutral = Matrixone Utils CI / Coverage
    • check-success = Matrixone Utils CI / Coverage

@mergify
mergify Bot merged commit ca7e3ba into matrixorigin:main May 20, 2026
23 of 24 checks passed
@mergify mergify Bot removed the queued label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengttt fengttt fengttt approved these changes
@aunjgr aunjgr aunjgr approved these changes
@heni02 heni02 heni02 approved these changes
@ouyuanning ouyuanning Awaiting requested review from ouyuanning
@XuPeng-SH XuPeng-SH Awaiting requested review from XuPeng-SH XuPeng-SH is a code owner

Assignees

No one assigned

Labels

kind/feature kind/test-ci size/L Denotes a PR that changes [500,999] lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Text/JSON functions OCTET_LENGTH and JSON_LENGTH not supported

6 participants

@ULookup @CLAassistant @fengttt @aunjgr @heni02 @matrix-meow