Revert "fix: skip already deleted relations in database delete (#24717)" - #24725
Merged
XuPeng-SH merged 1 commit intoMay 30, 2026
Merged
Conversation
…xorigin#24717)" This reverts commit 1285f0e.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
7 tasks
XuPeng-SH
pushed a commit
that referenced
this pull request
Jun 1, 2026
This reverts commit 0bfda60. ## What type of PR is this? - [ ] API-change - [x] BUG - [ ] Improvement - [ ] Documentation - [ ] Feature - [ ] Test and CI - [ ] Code Refactoring ## Which issue(s) this PR fixes: issue #24711 ## What this PR does / why we need it: Restore the main fix from #24717 after #24725 reverted it. The original fix is still needed for restore-account database delete: when a relation was already deleted in the current transaction, `Engine.Delete(database)` should skip that relation only when `tableOps.existAndDeleted` proves it was deleted, while preserving other errors. Tested with: ``` source $HOME/.zshrc && moenv && go test ./pkg/vm/engine/disttae ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1285f0e.
What type of PR is this?
Which issue(s) this PR fixes:
issue #24711
What this PR does / why we need it:
Revert "fix: skip already deleted relations in database delete (#24717)"
Tested with: