fix: address frontend vet failures - #25401
Merged
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
XuPeng-SH
force-pushed
the
fix/frontend-vet-coverage-4.1
branch
from
July 2, 2026 17:21
0d858cc to
63c994d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
#25402
What this PR does / why we need it:
This fixes two Go vet failures in
pkg/frontendthat block the coverage UT job on4.1-dev:SessionLogger.Errorinstead of passing zap fields to the printf-styleErrorf%dforint64values inTestTransformIntoHoursValidation:
go test -run 'TestTransformIntoHours|TestIsValidFrequency' -count=1 -vet=all ./pkg/frontendmatrixorigin/golang:1.26.4-ubuntu22.04):go test -json -short -v -tags matrixone_test -p 6 -covermode=set -coverprofile=frontend_coverage.raw -coverpkg="<CI full package scope>" ./pkg/frontend