Skip to content

v1.3.0 - correct ability data + stealth opener

Choose a tag to compare

@matt82198 matt82198 released this 01 Aug 21:11
· 76 commits to main since this release

An expert Outlaw review of the shipped v1.2 found the simulation was running on WRONG NUMBERS. Every ability value has now been re-verified against Wowhead with the source URL recorded inline.

CORRECTED (old -> new):

  • Dispatch energy 25 -> 35. This is the finisher a levelling character actually uses, so the basic builder->finisher loop was giving affordability advice off by 10 energy.
  • Blade Rush cost 25 -> 0, cooldown 10s -> 60s
  • Killing Spree cost 25 -> 45, cooldown 30s -> 180s
  • Between the Eyes cooldown 30s -> 45s
  • Blade Flurry cost 0 -> 15
  • Keep It Rolling cooldown 15s -> 360s

Wrong cooldowns silently corrupt a forward simulation, because the entire point is predicting when things come back up.

ALSO FIXED:

  • Ambush had NO priority rule at all - the addon skipped the stealth opener on every pull. It now leads the sequence when stealthed.
  • Simulated cooldowns never started (keyed by rule name instead of ability), so a predicted sequence could repeat the same ability.
  • A missing cooldown key returned a shared table, so one bad write corrupted later lookups for the session.

GUARDS ADDED: tests now assert the ability DATA itself, reject placeholder-looking values, and fail on back-to-back duplicates in a predicted sequence.

129 tests, three consecutive clean runs.