Merged
Conversation
Included the password reset section under "Administration Issues".
Closed
justinegeffen
suggested changes
Mar 12, 2020
Contributor
justinegeffen
left a comment
justinegeffen
left a comment
There was a problem hiding this comment.
Some structural changes suggested and minor questions. Happy to give it a second pass!
Contributor
|
Hey, @ahmaddanialmohd, wanted to follow up on this so you can take a look at the suggested changes. Thank you! :) |
Co-Authored-By: Justine Geffen <justinegeffen@users.noreply.github.com>
Contributor
Author
|
Looks good to me. Thank you, @justinegeffen ! |
Contributor
Thanks @ahmaddanialmohd. There are a few outstanding questions - are you open to taking a look at them? If you're happy with the suggested changes you're welcome to commit them and then I'll give it another pass. :) |
Contributor
|
Hi @ahmaddanialmohd. I've committed some of my suggestions as they were stylistic. Just one question regarding the SSO content and then we're good to go. :) |
Contributor
|
Fixes: #3077 Adding @amyblais for fresh eyes and @wiersgallak for review. |
amyblais
approved these changes
Mar 18, 2020
wiersgallak
reviewed
Mar 19, 2020
justinegeffen
approved these changes
Apr 15, 2020
wiersgallak
added
3: Reviews Complete
amyblais
removed
the
3: Reviews Complete
justinegeffen
pushed a commit
that referenced
this pull request
Apr 23, 2020
* master: (24 commits) Update desktop-changelog.rst (#3547) Update desktop-app-deployment.rst (#3541) v5.19.2 docs (#3544) Update changelog.md (#3545) Move PM hiring process to the handbook (#3543) Edited NPS rating options from 4 to 3. (for docs.mattermost.com) (#3494) Update important-upgrade-notes.rst (#3540) Update feature-release.md (#3489) Update mmctl-cli-tool.rst (#3514) Update desktop-changelog.rst (#3502) Fixing broken doc (#3536) About Mattermost page moved to handbook (#3525) Update version-archive.rst (#3533) V5.22 documentation (#3531) Update bulk-export-data.rst with post prop information (#3520) Updated to include Account and team setup events, system console events (#3518) Update working-at-mattermost.rst (#3532) Update feature parity table in product FAQ (#3509) Password Reset Section (#3443) Update integrations.rst (#3528) ... # Conflicts: # source/overview/faq.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included the password reset section under "Administration Issues".
Summary
Ticket Link