MM-70112: Add business-days option for PR review SLA due dates

[jgheithcock]

Summary

Adds a System Console setting for PR review SLA day type: Calendar days (default, existing behavior) or Business days (Mon-Fri). Business mode only changes how the due date is computed from "PR review target (days)"; overdue age and digest buckets stay calendar days.

QA:

1. Open System Console > Plugins > GitHub.
2. Set PR review target (days) to 2 and day type to Calendar days. Request a review Friday > Monday shows overdue.
3. Switch day type to Business days (Mon-Fri). Same request Friday > Monday shows due later (due Tuesday).
4. Confirm default Calendar days leaves prior installs unchanged.
5. Confirm /github todo, RHS badges, and overdue digest stay consistent with the selected mode.

Ticket Link

https://mattermost.atlassian.net/browse/MM-70112

Screenshots

N/A

Release Note

Added a GitHub plugin setting to count PR review SLA targets in calendar days or business days (Mon-Fri).

Change Impact: 🟡 Medium

Reasoning: The change spans configuration, shared SLA utilities, frontend selectors, badges, todo views, and digests. Existing behavior remains unchanged by default, with tests covering key calendar and business-day paths.

Regression Risk: Medium. Shared SLA utilities and user-facing review status flows changed. Weekend boundaries, configuration propagation, and consistent configuration snapshots require validation.

QA Recommendation: Perform focused manual QA for calendar and business-day settings across /github todo, RHS badges, and overdue digests. Skipping manual QA carries moderate risk.

Generated by CodeRabbitAI

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e7638240-01fc-4fd4-ab63-883819b27049

📥 Commits

Reviewing files that changed from the base of the PR and between a9abd4d and 3b2a20a.

📒 Files selected for processing (1)

• server/plugin/sla_digest.go

🚧 Files skipped from review as they are similar to previous changes (1)

• server/plugin/sla_digest.go

---

📝 Walkthrough

Walkthrough

The plugin adds a configurable review SLA day type. It supports calendar days and Monday–Friday business days. The setting flows through server calculations, digest messages, client state, sidebar controls, and SLA badges.

Changes

SLA day type support

Layer / File(s)	Summary
Configuration and typed state plugin.json, server/plugin/configuration.go, webapp/src/reducers/index.ts, webapp/src/selectors.ts, webapp/src/types/github_types.ts	The configuration adds ReviewTargetDayType. The server normalizes it. The web application stores, types, and exposes the normalized value.
Calendar and business-day calculation server/plugin/utils.go, server/plugin/utils_test.go, webapp/src/utils/sla.ts, webapp/src/utils/sla.test.ts	SLA utilities support calendar-day and weekday-only calculations. Tests cover normalization, weekend skipping, due dates, and overdue status.
Server review and digest integration server/plugin/plugin.go, server/plugin/sla_digest.go, server/plugin/sla_digest_test.go	Review todo formatting and digest overdue evaluation use the configured day type. Digest headings identify calendar days or business days.
Sidebar SLA rendering webapp/src/components/sidebar_buttons/*, webapp/src/components/sidebar_right/*, webapp/src/components/sidebar_buttons/sidebar_buttons.test.jsx	Sidebar controls and SLA badges receive the configured day type and pass it to SLA status evaluation.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Configuration
  participant getSidebarData
  participant SidebarButtons
  participant GithubItems
  participant getReviewSLAStatus
  Configuration->>getSidebarData: provide review_target_day_type
  getSidebarData->>SidebarButtons: expose reviewTargetDayType
  getSidebarData->>GithubItems: expose reviewTargetDayType
  SidebarButtons->>getReviewSLAStatus: evaluate overdue reviews with day type
  GithubItems->>getReviewSLAStatus: calculate badge status with day type
  getReviewSLAStatus-->>SidebarButtons: return SLA status
  getReviewSLAStatus-->>GithubItems: return SLA status

Loading

Poem

A rabbit counts the weekdays bright,
Skips the weekend out of sight.
Calendar paws or business cheer,
Guide each SLA through the year.
Tidy badges bloom just right.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding business-day support for pull request review SLA due dates.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mm-70112

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@server/plugin/sla_digest.go`:
- Line 90: Use a single normalized day-type snapshot throughout the SLA digest
flow: compute it before scanning, pass it into collectAllOverdueSLAItems, and
reuse that same value when buildSLADigestMessage constructs the header instead
of rereading cfg via reviewTargetDayType().

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 620e1862-c362-4ea1-a9e1-6fa05c705e60

📥 Commits

Reviewing files that changed from the base of the PR and between 69aea52 and a9abd4d.

📒 Files selected for processing (18)

• plugin.json
• server/plugin/configuration.go
• server/plugin/plugin.go
• server/plugin/sla_digest.go
• server/plugin/sla_digest_test.go
• server/plugin/utils.go
• server/plugin/utils_test.go
• webapp/src/components/sidebar_buttons/index.js
• webapp/src/components/sidebar_buttons/sidebar_buttons.jsx
• webapp/src/components/sidebar_buttons/sidebar_buttons.test.jsx
• webapp/src/components/sidebar_right/github_items.tsx
• webapp/src/components/sidebar_right/index.jsx
• webapp/src/components/sidebar_right/sidebar_right.jsx
• webapp/src/reducers/index.ts
• webapp/src/selectors.ts
• webapp/src/types/github_types.ts
• webapp/src/utils/sla.test.ts
• webapp/src/utils/sla.ts

[avasconcelos114]

LGTM! Nice to see this being included 😄