Skip to content

Fix profile hover url when enterprise url is set - #49

Merged
crspeller merged 2 commits into
mattermost:masterfrom
sandeepsukhani:42-hover-url
Feb 22, 2019
Merged

Fix profile hover url when enterprise url is set#49
crspeller merged 2 commits into
mattermost:masterfrom
sandeepsukhani:42-hover-url

Conversation

@sandeepsukhani

@sandeepsukhani sandeepsukhani commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

Url shown in profile hover always points to github.com/<username> instead of <enterprise-url>/<username>
This fixes the url to point to correct address

Fixes #42

Url shown in profile hover always points to github.com/<username> instead of <enterprise-url>/<username>
This fixes the url to point to correct address

Fixes mattermost#42
@hanzei
hanzei requested review from hanzei and jwilander February 22, 2019 10:38
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Feb 22, 2019
@hanzei
hanzei requested review from crspeller and jwilander and removed request for hanzei and jwilander February 22, 2019 10:39

@jwilander jwilander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@crspeller
crspeller self-requested a review February 22, 2019 15:51
@crspeller
crspeller merged commit 5a4b08e into mattermost:master Feb 22, 2019
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 22, 2019
IndushaS pushed a commit to IndushaS/mattermost-plugin-github that referenced this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

userprofile hover github url is pointing to github.com

4 participants