bridgev2/matrix: allow canceling a single step - #560
Merged
Conversation
radon-at-beeper
marked this pull request as ready for review
August 27, 2026 18:19
wait step returns an error saying it was cancelled. the next step is returned by the cancel call, not by the wait step. as part of that, change the CancelUserInput to a generic CancelStep so it's used for any type of step that supports cancellation, rather than the Wait being responsible for checking the context passed to it.
tulir
approved these changes
Aug 28, 2026
tulir
left a comment
tulir
left a comment
Member
There was a problem hiding this comment.
Looks correct, we should probably write unit tests for the provisioning login state machine at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.