appservice/intent: allow setting avatar when profile field is missing - #563
Closed
PolynomialDivision wants to merge 1 commit into
Closed
appservice/intent: allow setting avatar when profile field is missing#563PolynomialDivision wants to merge 1 commit into
PolynomialDivision wants to merge 1 commit into
Conversation
Homeservers may return M_NOT_FOUND when avatar_url has not been set for a profile yet, for example Tuwunel. SetAvatarURL previously treated this valid response as a fatal error and returned before sending the new avatar. Treat M_NOT_FOUND as an empty avatar and continue with the PUT request. All other errors remain fatal.
jevolk
added a commit
to matrix-construct/tuwunel
that referenced
this pull request
Sep 1, 2026
Since the spec folded these endpoints into the generic field route, the only unset-field response is a 404 no other server sends and clients treat as fatal (mautrix/go#563); custom keys keep the MSC4133 404. Signed-off-by: Jason Volk <jason@zemos.net>
jevolk
added a commit
to matrix-construct/tuwunel
that referenced
this pull request
Sep 1, 2026
Since the spec folded these endpoints into the generic field route, the only unset-field response is a 404 no other server sends and clients treat as fatal (mautrix/go#563); custom keys keep the MSC4133 404. Signed-off-by: Jason Volk <jason@zemos.net>
Author
|
@jevolk Thanks for adding the tuwunel fix. However, this PR should still be merged because your commit is just a workaround? |
Member
|
The spec might get changed instead to define that displayname/avatar_url return 200 even when unset, because that was the behavior in all servers pre-MSC4133: https://matrix.to/#/!0KNSXYXB_2xtEUkQ9MGBRy5oNIOfAKoq2uIqPZCJbI8/%24DILQ8eUyvHbDB9eXFNQ-jnDYN0XcH9LM4yf_5D8Be1s?via=maunium.net&via=matrix.org&via=element.io |
Author
|
Okay, so I will close? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homeservers may return M_NOT_FOUND when avatar_url has not been set for a profile yet, for example Tuwunel. SetAvatarURL previously treated this valid response as a fatal error and returned before sending the new avatar.
Treat M_NOT_FOUND as an empty avatar and continue with the PUT request. All other errors remain fatal.
Checklist