login: Native login flow w/ recaptcha webview - #89
Conversation
|
|
||
| var _ bridgev2.LoginProcessCookies = (*SlackTokenLogin)(nil) | ||
|
|
||
| const ExtractSlackTokenJS = ` |
There was a problem hiding this comment.
All the changes in this file from this point onwards seem to be wrong
There was a problem hiding this comment.
Yep, not sure what's going on here we shouldn't be messing with the existing cookies/webview flow at all 🤔
There was a problem hiding this comment.
I left it in as an unrelated change, did not mean to push it 😬
| }, { | ||
| Name: "Auth token & cookie", | ||
| Description: "Log in with an auth token (and a cookie, if the token is from a browser)", | ||
| Description: "Advanced: sign in with an existing auth token and cookie token", |
There was a problem hiding this comment.
| Description: "Advanced: sign in with an existing auth token and cookie token", | |
| Description: "Log in with an auth token (and a cookie, if the token is from a browser)", |
There was a problem hiding this comment.
This doesn't look like it should be a separate file. However, the login API stuff (unrelated to bridgev2) and the bridgev2 login interface should be 2 separate files. The login API stuff might even belong in slackgo rather than here, though it's fine here too if it's cleanly separated
| @@ -0,0 +1,960 @@ | |||
| // mautrix-slack - A Matrix-Slack puppeting bridge. | |||
| // Copyright (C) 2024 Tulir Asokan | |||
There was a problem hiding this comment.
This is supposed to be the current year and your name
|
|
||
| var _ bridgev2.LoginProcessCookies = (*SlackTokenLogin)(nil) | ||
|
|
||
| const ExtractSlackTokenJS = ` |
There was a problem hiding this comment.
Yep, not sure what's going on here we shouldn't be messing with the existing cookies/webview flow at all 🤔
3 participants
Checklist