Add DM-only mode for local Slack - #93
Open
KishanBagaria wants to merge 22 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a “DM-only” operating mode for the Slack connector, intended to restrict discovery/sync/event handling to direct messages (IMs) and group DMs (MPIMs), while omitting channel data where possible.
Changes:
- Introduces
dm_onlyconfiguration and config upgrader support. - Uses Slack client boot options to omit channel data when
dm_onlyis enabled. - Filters incoming Slack events and adjusts channel sync logic to ignore non-DM conversations in DM-only mode.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/connector/startchat.go | Blocks channel creation when dm_only is enabled. |
| pkg/connector/login-cookie.go | Uses boot options to omit channels during cookie/token login when dm_only is enabled. |
| pkg/connector/handleslack.go | Filters events to DM channels only; adds helper to extract channel ID from events. |
| pkg/connector/example-config.yaml | Documents the new dm_only config option. |
| pkg/connector/config.go | Adds DMOnly to config struct and config upgrade path. |
| pkg/connector/client.go | Tracks DM channel IDs; boots and syncs differently under dm_only. |
| pkg/connector/capabilities.go | Hides public/private channel creation capability when dm_only is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| for _, ch := range s.BootResp.Channels { | ||
| ch.IsMember = true | ||
| channels = append(channels, &ch.Channel) | ||
| if s.Main.Config.DMOnly || (s.IsRealUser && (strings.HasPrefix(token, "xoxs-") || s.Main.Config.Backfill.ConversationCount == -1)) { |
tulir
reviewed
Aug 7, 2026
KishanBagaria
force-pushed
the
kb/dm-only
branch
from
August 7, 2026 20:30
e300778 to
dbe2271
Compare
KishanBagaria
commented
Aug 8, 2026
| } | ||
| // TODO do actual warm boots by saving last received ts somewhere | ||
| bootResp, err = s.Client.ClientUserBootContext(ctx, time.Time{}) | ||
| bootResp, err = s.Client.ClientUserBootContext(ctx, time.Time{}, s.Main.Config.DMOnly) |
Author
There was a problem hiding this comment.
slack is actually ignoring omit_channels and still returning it. keeping it in case bot logins are different
KishanBagaria
commented
Aug 8, 2026
| pages := 0 | ||
| output = make(map[networkid.UserID]bridgev2.ChatMember) | ||
| for limit > 0 { | ||
| chunkLimit := limit |
Author
There was a problem hiding this comment.
bug in main - chunkLimit was unused
KishanBagaria
commented
Aug 8, 2026
| const maxSlackPaginationPages = 1000 | ||
|
|
||
| func slackPageLimit(unlimited bool, remaining int) int { | ||
| const maxPage = 200 |
Author
There was a problem hiding this comment.
@tulir any reason to do 200 max here? i tested users.conversations accepts limit=999 (it returned my 828 DMs/MPIMs in 1 req)
this will reduce users.conversations from 5 requests to 1 for me
Author
|
@tulir good for re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on beeper/slackgo#4