refactor: remove build.rs and runtime resource copying at build time - #171
Merged
Conversation
Collaborator
|
Sorry, why do you think we should remove this entirely? Pretty good fallback at pretty low cost imo @qaqland |
Contributor
Author
|
Usually, build.rs are meant to help with compilation only and shouldn't touch user configuration directories.
|
Collaborator
|
Thanks for the clarification, just didn't know the intent here. We'll make sure this is handled on the packaging side. |
philocalyst
self-requested a review
March 24, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref 65ffea7