Skip to content

test: add core coverage gate - #45

Merged
max23468 merged 2 commits into
mainfrom
codex/atlas-test-coverage
Jun 2, 2026
Merged

test: add core coverage gate#45
max23468 merged 2 commits into
mainfrom
codex/atlas-test-coverage

Conversation

@max23468

@max23468 max23468 commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a canonical Vitest coverage command and core-module threshold config
  • expand tests for storage/fs/time and critical fetch/report/summary/text branches
  • add a PR quality workflow for test, core coverage and build on Node 24
  • document the Atlas coverage workflow in README and toolchain

Atlas Coverage

  • configured core perimeter: src/config.ts, src/dashboard.ts, src/fetch-resource.ts, src/fs.ts, src/report.ts, src/storage.ts, src/summary.ts, src/text.ts, src/time.ts, src/url.ts
  • threshold: 75% lines, 65% branches
  • measured baseline on the same perimeter: 71.65% lines, 53.26% branches
  • measured current result: 87.4% lines, 65.35% branches

Residual Gap

  • numeric gap vs Atlas threshold on the configured core perimeter: none
  • stability margin on branches is still narrow: +0.35 points over the 65% threshold
  • qualitative gap still visible in covered core files: src/dashboard.ts branch coverage is 43.8% and remains the next high-value target
  • out of scope for this PR: src/index.ts, src/scan.ts, src/email.ts, src/dashboard-publish.ts

Next Step

  • add a focused follow-up on src/dashboard.ts states and branches to raise branch margin above the bare threshold and make the core perimeter less fragile

Verification

  • npm test
  • npm run test:coverage
  • npm run build
  • git diff --check

@max23468
max23468 marked this pull request as ready for review June 2, 2026 22:26
@max23468
max23468 merged commit 9bed3ae into main Jun 2, 2026
6 checks passed
@max23468
max23468 deleted the codex/atlas-test-coverage branch June 2, 2026 22:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9bafe177af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/pr-quality.yml
@github-actions github-actions Bot mentioned this pull request Jun 2, 2026
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant