Report Phase working/idle state to Herdr#64
Merged
Conversation
Ship Phases no longer rely on Cursor screen-detection cues for multiplexer sidebars: under HERDR_* env, report-agent marks working for the Phase and idle on every exit path, and no-ops outside Herdr.
Deduplicate the Iteration/Phase/Ticket join used by wait UI and multiplexer reports, and rename Herdr Agent to AgentID so it does not clash with the coding Agent port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ship Phases no longer rely on Cursor screen-detection cues for multiplexer sidebars. When
HERDR_ENV/HERDR_SOCKET_PATH/HERDR_PANE_IDare set, the Run orchestrator reportsworkingat Phase start (with the same Iteration · Phase · Ticket label as the throbber) andidleon every exit path viaherdr pane report-agent. Outside Herdr the reporter is a no-op, so normal terminals and CI are unchanged.Linked issues
RISK
SIGKILL) mid-Phase, the deferredidlereport never runs and the Agents row can stay on working until Herdr’s own timeout/fallback. Affected: operators watching Ship inside a Herdr pane.herdr(orHERDR_BIN_PATH). A breaking CLI change or incomplete env still no-ops or fails best-effort and does not Abort the Run, but the sidebar may stay wrong. Affected: Herdr users only.herdrprocess spawn per Phase boundary (very low): each Working/Idle call execs the CLI when under Herdr. Unlikely to matter unless Phase boundaries are extremely frequent; does not change Agent work itself.QA — stress-test plan for a human
Happy path
go test ./...,staticcheck ./..., and a normalshipRun (or--help/ dry queue) in a plain terminal. Confirm noherdrinvocations and no behavior change on the throbber (Iteration N · Phase · #ticket).HERDR_ENV=1,HERDR_SOCKET_PATH, andHERDR_PANE_IDset: start a Run that reaches at least one Implement Phase (ship-labeled Ticket, confirm queue). While the Phase is running, check the Agents sidebar: Ship/ship:runshould show working with a message likeIteration 1 · Implement · #<n> …. When the Phase ends (success), it should return to idle. Repeat for Review and Final if the Run gets that far.Edges / failure cases
agent, or a short timeout): sidebar must still flip to idle after Ship Aborts; unfinished Tickets keep the ship label as before.herdrmissing fromPATH(or a brokenHERDR_BIN_PATH): Run must still complete / Abort normally; missing CLI must not fail the Phase.HERDR_ENV=1withoutHERDR_PANE_ID): must no-op like outside Herdr.Out of scope