The mascot's points burst: #16 said drop it, #160 renumbered it instead

[maximsan]

This was generated by AI during triage.

Half of this is superseded by #518. The pose is drawn again, on the terms this ticket rejected: the amount is passed in, required with the state and rejected without it, so the mascot still names no payout of its own. What stands is the rest — no v1 moment that already celebrates gets a second one wired into it, so nothing calls the pose. It waits for Coffee Duel's round-complete beat, where the design puts it.

Follow-up owed by #160. A disposition of #16 that #160 was built to implement, and missed.

What #16 ruled

roasty_particles.dart:171 hardcodes a '+15 XP' particle matching no rule in the app — not perStep, not the module bonus. It goes with the toast.

and, in the same comment's disposition table:

'+15 XP' in roasty_particles.dart:171	Dropped	Matches no rule in the app; a hardcoded string

What #160 did instead

Renumbered it. The vocabulary sweep rewrote the literal to '+10 PTS' and named it a placeholder constant, which fixed the word and left the defect — a payout hardcoded into painted art. Ten is no more read from a rule than fifteen was.

It is invisible to tooling: the particles file is excluded from no-magic-number, and that exclusion is justified for coordinates, not for payouts.

Why deleting is the answer, not parameterizing

The pose has never rendered. CompanionReaction.xpGained is fired by nothing; RoastyState.xp is reachable only through it. So no learner has seen the wrong number, and nothing would have caught it.

The alternative — keep the pose and pass the real payout in, as the design does (roasty.jsx:575 renders +{pointsAmount} PTS) — was considered and rejected at triage. The lesson result screen already plays CompanionReaction.lessonComplete, and §5.1 puts points on that same screen. Wiring a second celebration into one moment is a design decision about what happens to the first, which is scope this ticket has no business carrying.

This ticket therefore deletes. If a points-earned moment is ever wanted, it is authored deliberately against a screen that has room for it — not inherited from an unreferenced pose carrying a stale number.

Related

The unwired-pose gap is broader than this ticket and is split out to #219: correct, wrong and cardEarned are also fired from nowhere, and §5.1 asks for the first two by name.

[maximsan]

This was generated by AI during triage.

Agent Brief

Category: bug
Summary: Delete the mascot's points-burst pose, which #16 ruled dropped and #160 renumbered instead

Current behavior:
The companion has a points-earned pose that paints a rising chip reading a hardcoded payout. #16 ruled that literal dropped ("it goes with the toast"); #160's vocabulary sweep rewrote it from +15 XP to +10 PTS and named the constant, leaving a payout baked into painted art. A lesson's payout is per-lesson authored data, so no constant here can be right.

The pose is unreachable: the companion reaction that selects it is fired from nowhere in the app, so the mascot state behind it is unreachable too. Nothing renders it and no test would catch a wrong number in it. The particles file is excluded from no-magic-number, so the linter will not flag the literal either.

Desired behavior:
The pose is gone, root and branch — the reaction, the mascot state it maps to, the particle painter, the face painter and the animation timings keyed to that state. No half-deleted pose: an enum value with no painter, or a painter with no enum value, is worse than what is there now.

No payout literal survives anywhere in the companion layer.

Key interfaces:

• The companion reaction enum — remove the points-earned member. Its mapping to a mascot state goes with it, and the mapping function must stay total over the enum with no default case added to hide the removal.
• The mascot state enum — remove the member the reaction mapped to. Every switch over it (particles front/back, faces, animation duration and replay behaviour) must remain exhaustive by construction, not by falling through a default.
• The particle painter for that state, its placeholder label constant, and the face painter for that state — all deleted, not left unreferenced.
• Tests naming the removed state or reaction are deleted, not adapted. They assert a pose that will not exist.

Acceptance criteria:

• No identifier for a points-earned companion reaction or mascot state remains in lib/ or test/
• No payout literal (+10 PTS, +15 XP, or any successor) appears anywhere in the companion presentation layer
• Every switch over the mascot-state enum is exhaustive without a default/_ arm added by this change
• The other eight companion reactions and their poses are untouched and still render
• dart analyze is clean across lib, test and integration_test
• dart run dart_code_linter:metrics analyze lib is clean
• The full test suite passes, with the tests for the deleted pose removed rather than skipped
• A changelog entry records the deletion and cites Points and mastery: reconciling a materially different progression game #16's disposition

Out of scope:

• The other unwired poses. correct, wrong and cardEarned are also fired from nowhere. They are a separate question — §5.1 asks for the first two by name — and are tracked on their own ticket. Do not delete them, and do not wire them.
• Wiring any points-earned moment. If one is ever wanted it is authored against a screen chosen for it. The lesson result screen already plays the lesson-complete pose.
• The no-magic-number exclusion on the particles file. It is correct for coordinates and stays.
• Any change to the points rules. Points pay flat 10, once: retire the per-step XP engine #160 settled them; this is cleanup of a disposition it missed.