Conversation
Merged
Collaborator
|
Seems file although I didn't look at the implementation closely. I confirmed the results from your example through the input/output pipeline: |
maxitg
added a commit
that referenced
this pull request
Mar 1, 2021
## Changes * `PostTagSearcher` now correctly uses the time constraint parameter. * `ConclusionReason` will either be `TimeConstraintExceeded` or `NotEvaluated` based on whether the time constraint was reached before or during the evaluation of a particular init. ## Comments * Checkpoints #21 should be merged first. * The time constraint will be exceeded slightly because results need to be collected. ## Examples * The first result of the following concludes with reason `TimeConstraintExceeded`: ```c++ PostTagSearcher::EvaluationParameters parameters; parameters.groupTimeConstraintNs = 100000000; // 0.1 seconds const auto result = PostTagSearcher().evaluateRange( 64, 1473593303835332608, 1473593303835332609, parameters); ``` * The other two results are `NotEvaluated` for now, but that can change after parallelization is implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
PostTagSearchernow uses explicit checkpoints fromEvaluationParameters.Comments
"ReachedCycle"and"MergedWithAnotherInput") conclusions.Examples
PostTagSearcher::EvaluationParameters parameters; parameters.checkpoints = {{{0, 0, 0, 1, 1, 1, 0, 0, 0, 1, 1, 1, 0}, 2}}; const auto result = PostTagSearcher().evaluateRange(20, 123, 125, parameters);This change is