Conversation
Collaborator
|
Would you be able to add an option (e.g. an |
Owner
Author
|
@okofish, sure, I'll do that. |
1b8463c to
9cd6981
Compare
Owner
Author
Done. |
okofish
reviewed
Mar 1, 2021
| // TimeConstraintExceeded conclusion reason. The aborted evaluations will have EvaluationResult filled in with | ||
| // values obtained so far. The remaining ones will be filled with zeros. | ||
| uint64_t groupTimeConstraintNs = std::numeric_limits<uint64_t>::max(); | ||
| int64_t groupTimeConstraintNs = std::numeric_limits<int64_t>::max(); |
Collaborator
There was a problem hiding this comment.
Oh no, now we can only run for 292 years instead of 584!
okofish
approved these changes
Mar 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
PostTagSearchernow correctly uses the time constraint parameter.ConclusionReasonwill either beTimeConstraintExceededorNotEvaluatedbased on whether the time constraint was reached before or during the evaluation of a particular init.Comments
Examples
TimeConstraintExceeded:NotEvaluatedfor now, but that can change after parallelization is implemented.This change is