Teach Reader to use a URL #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 1, 2013 18:07
These objects are in the same package as the Test, and thus do not require import.
Updated the test to exercise both the File and the URL flavors.
Since this project is Open Source, it is very handy to have Maven download the sources for the jars found in central. Some projects also attach javadoc, but the sources provide javadoc (at least with IJ) so I find that they just take up space.
Member
There was a problem hiding this comment.
AFAIK, this can return -1, which will cause the next line to fail
Author
There was a problem hiding this comment.
Yes, I had forgotten about that. However, if we go with the BAOS mechanism you mention below, then we won't need content-length and this bug goes away.
added 2 commits
November 4, 2013 10:36
InputStream is the common denominator and contains enough information to construct the ThreadBuffer (and thus the Reader).
Those warnings in IJ hide potentially real bugs.
Author
|
I switched to the BAOS as we discussed and (of course) all the tests pass. I'll update the GeoIP2-java PR in a second. |
ghost
merged commit 
Member
|
Thanks! 👍 |
TuxCoding
referenced
this pull request
in TuxCoding/MaxMind-DB-Reader-java
Mar 15, 2018
Add the missing cache files
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are circumstances under which one does not have access to a
Fileand it seems unnecessary to open anInputStreamonly to serialize it to aFilewhich is then subsequently read back into memory due to the constructorReader(File).Thus, this PR adds a constructor to
Readerthat accepts aURL.I briefly thought about going to the next logical conclusion and adding one for
InputStreambut I am not familiar enough with NIO to avoid building up aList<byte>since I would not know the length of the incoming stream.I will also submit a PR for
com.maxmind.geoip2.DatabaseReaderover in GeoIP2-java to expose the new functionality.