Fail with a more useful error message when MODE_MMAP_EXT is chosen but the extension isn't available #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafl
force-pushed
the
rafl/mmap-ext-without-extension
branch
from
2198948 to
144aa9d
Compare
oschwald
requested changes
Jan 31, 2017
Member
oschwald
left a comment
oschwald
left a comment
There was a problem hiding this comment.
Looks good. Just one comment on the exception type.
maxminddb/__init__.py
Outdated
| has_extension = maxminddb.extension and hasattr(maxminddb.extension, 'Reader') | ||
| if (mode == MODE_AUTO and has_extension) or mode == MODE_MMAP_EXT: | ||
| if not has_extension: | ||
| raise ImportError( |
Member
There was a problem hiding this comment.
I think I'd expect a ValueError if I passed an invalid parameter, not an ImportError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.