Added pure Python implementation #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the tests pass. On my machine, the reader does about 2000 lookups per second with CPython and about 7000 with PyPy. I am still working on getting the conditional loading of the C extension working. To do that, I need to make some changes to the extension itself.
Also brought the errors in line with the pure Python module.
For closed files. Also temporarily disabled a test. (Didn't use skip as it isn't working on 2.6.)
autarch
added a commit
that referenced
this pull request
Feb 11, 2014
Added pure Python implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is fine to release as beta. We may want to refactor the code a bit going forward, but I think it is in a usable state as is.