Remove stale maxmind-db entry from .gitmodules - #469
Conversation
Commit 5f499c1 (2014) moved the maxmind-db submodule to t/maxmind-db and deleted the gitlink at the top-level path, but left the old [submodule "maxmind-db"] stanza in .gitmodules. This was harmless until Dependabot gitsubmodule updates were enabled (8161529). Dependabot parses .gitmodules and fetches each declared path via the GitHub contents API; GET /contents/maxmind-db returns 404, so every update run aborts with dependency_file_not_found, which in turn trips the Dependabot Failure Watcher. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes a stale maxmind-db submodule entry from .gitmodules that no longer exists in the repository tree, which was causing Dependabot’s git submodule update job to abort when it attempted to fetch maxmind-db via the GitHub Contents API.
Changes:
- Removed the obsolete
[submodule "maxmind-db"]stanza whosepath = maxmind-dbno longer exists. - Leaves the active submodules (
t/libtapandt/maxmind-db) unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Problem
The Dependabot Failure Watcher failed (run 31018162189) because the first scheduled gitsubmodule update run (run 30941152746, enabled in #465) aborted with:
.gitmodulesdeclared three submodules, but the repo tree only contains two gitlinks (t/libtapandt/maxmind-db). Commit 5f499c1 (2014) moved the submodule frommaxmind-dbtot/maxmind-dbbut left the old[submodule "maxmind-db"]stanza behind. Dependabot fetches each declared path via the GitHub contents API;GET /contents/maxmind-dbreturns 404, aborting the whole job.Fix
Remove the stale stanza. Nothing references a top-level
maxmind-dbcheckout (thet/Makefile.amreference is relative tot/).Verification
Replicating Dependabot's per-path contents API lookup (the exact request that failed in the job log):
On main (
5886ccf):On this branch (
8c33c0c):🤖 Generated with Claude Code
Summary by CodeRabbit