Add google style #259
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shadromani
force-pushed
the
sromani/checkstyle
branch
from
November 29, 2022 20:05
07b10cc to
be18220
Compare
shadromani
force-pushed
the
sromani/checkstyle
branch
from
November 29, 2022 20:16
be18220 to
0da4a62
Compare
oschwald
approved these changes
Nov 29, 2022
oschwald
left a comment
oschwald
left a comment
Member
There was a problem hiding this comment.
Looks good. We should probably create a follow-up story to add a GitHub Action workflow to enforce this. Otherwise, people are likely to ignore it.
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import org.apache.commons.validator.routines.DomainValidator; | ||
| import org.apache.commons.validator.routines.EmailValidator; |
Member
There was a problem hiding this comment.
It doesn't matter either way, but it looks like the previous style separated out built-ins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.